Re: [Qemu-devel] [PATCH 04/10] linux-user: Sync fcntl.h bits with the kernel

[Richard Henderson]

On 2012-08-02 07:34, Peter Maydell wrote:
> No entries for TARGET_M68K? I checked and I think that's the
> only supported arch which isn't listed here and isn't only using
> the asm-generic values. (It's the same 4 defines as TARGET_ARM.)

I didn't notice because it was missing beforehand.

> The other targets were all straightforward to review but I had a
> little difficulty with the Alpha bits here.
> (1) O_LARGEFILE is 0 here but not in the kernel. Does the "not
> necessary" comment here mean "not necessary for QEMU" ?
> (ie is the difference because we are taking a different approach to
> the kernel's "always set this bit on entry" one ?)

Yes.  The fact that the kernel forces O_LARGEFILE set means that
from an ABI perspective it might as well be zero.  The fact that
it is defined to non-zero in kernel headers is merely historical,
and probably to document that the bit was used once.

> 
> (2) where has the TARGET_FASYNC entry come from?

You mean why isn't it using the default below?  Good question...


r~