[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH][RFC] Add compare subcommand for qemu-img
From: |
Miroslav Rezanina |
Subject: |
Re: [Qemu-devel] [PATCH][RFC] Add compare subcommand for qemu-img |
Date: |
Thu, 2 Aug 2012 06:06:36 -0400 (EDT) |
----- Original Message -----
> From: "Paolo Bonzini" <address@hidden>
> To: "Miroslav Rezanina" <address@hidden>
> Cc: address@hidden
> Sent: Wednesday, August 1, 2012 12:22:50 PM
> Subject: Re: [PATCH][RFC] Add compare subcommand for qemu-img
>
> > + goto out;
> > + }
> > + }
> > + over_num += nb_sectors;
> > + qemu_progress_print(((float) nb_sectors /
> > progress_base)*100, 100);
>
> qemu_progress_print(nb_sectors, over_sectors);
>
>
> Paolo
>
This won't work. qemu_progress_print takes either (current_progress,0) or
(progress_delta,progress_part) where all values are in percents - values in
range (0,100). If we pass (nb_sectors,over_sectors) we get 100% thanks to the
formula:
nb_sectors / 100 * over_sectors
Mirek