[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 06/10] vmstate: add VMSTATE_TIMER_V
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH 06/10] vmstate: add VMSTATE_TIMER_V |
Date: |
Thu, 02 Aug 2012 11:02:58 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120615 Thunderbird/13.0.1 |
Il 02/08/2012 10:56, Juan Quintela ha scritto:
>> > @@ -503,8 +503,11 @@ extern const VMStateInfo vmstate_info_unused_buffer;
>> > #define VMSTATE_TIMER_TEST(_f, _s, _test) \
>> > VMSTATE_POINTER_TEST(_f, _s, _test, vmstate_info_timer, QEMUTimer *)
>> >
>> > +#define VMSTATE_TIMER_V(_f, _s, _v) \
>> > + VMSTATE_POINTER(_f, _s, _v, vmstate_info_timer, QEMUTimer *)
>> > +
>> > #define VMSTATE_TIMER(_f, _s) \
>> > - VMSTATE_TIMER_TEST(_f, _s, NULL)
>> > + VMSTATE_POINTER(_f, _s, 0, vmstate_info_timer, QEMUTimer *)
> You didn't did it, it should be something like:
>
> #define VMSTATE_TIMER(_f, _s) \
> - VMSTATE_TIMER_TEST(_f, _s, NULL)
> + VMSTATE_TIMER_V(_f, _s, 0)
I'm following the other examples:
#define VMSTATE_UINT16_EQUAL(_f, _s) \
VMSTATE_SINGLE(_f, _s, 0, vmstate_info_uint16_equal, uint16_t)
#define VMSTATE_UINT16_EQUAL_V(_f, _s, _v) \
VMSTATE_SINGLE(_f, _s, _v, vmstate_info_uint16_equal, uint16_t)
but I can change it as you indicated.
Paolo
- [Qemu-devel] [PATCH 0/10] Remove periodic wakeup from RTC timer, Paolo Bonzini, 2012/08/01
- [Qemu-devel] [PATCH 01/10] RTC: Remove the logic to update time format when DM bit changed, Paolo Bonzini, 2012/08/01
- [Qemu-devel] [PATCH 02/10] RTC: Rename rtc_timer_update, Paolo Bonzini, 2012/08/01
- [Qemu-devel] [PATCH 03/10] RTC: Update interrupt state when interrupts are masked/unmasked, Paolo Bonzini, 2012/08/01
- [Qemu-devel] [PATCH 06/10] vmstate: add VMSTATE_TIMER_V, Paolo Bonzini, 2012/08/01
- [Qemu-devel] [PATCH 06/10] RTC: Add divider reset support, Paolo Bonzini, 2012/08/01
- [Qemu-devel] [PATCH 05/10] RTC: Update the RTC clock only when reading it, Paolo Bonzini, 2012/08/01
- [Qemu-devel] [PATCH 07/10] RTC: Do not fire timer periodically to catch next alarm, Paolo Bonzini, 2012/08/01
- [Qemu-devel] [PATCH 09/10] RTC: Remove the current_tm field, Paolo Bonzini, 2012/08/01
- [Qemu-devel] [PATCH 08/10] RTC: Get and set time without going through s->current_tm, Paolo Bonzini, 2012/08/01
- [Qemu-devel] [PATCH 10/10] RTC: Allow to migrate from old QEMU, Paolo Bonzini, 2012/08/01