[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v2 2/6] sparc: fix expression with uninitialized ini
From: |
Blue Swirl |
Subject: |
[Qemu-devel] [PATCH v2 2/6] sparc: fix expression with uninitialized initial value |
Date: |
Wed, 1 Aug 2012 18:21:07 +0000 |
err was uninitialized, it's not OK to use |=. Spotted by Clang
compiler.
Fix by implementing the earlier statement which initializes the variable.
Signed-off-by: Blue Swirl <address@hidden>
---
linux-user/signal.c | 8 +++-----
1 files changed, 3 insertions(+), 5 deletions(-)
diff --git a/linux-user/signal.c b/linux-user/signal.c
index 9be5ac0..7869147 100644
--- a/linux-user/signal.c
+++ b/linux-user/signal.c
@@ -1844,7 +1844,7 @@ typedef struct {
} __siginfo_t;
typedef struct {
- unsigned long si_float_regs [32];
+ abi_ulong si_float_regs[32];
unsigned long si_fsr;
unsigned long si_fpqdepth;
struct {
@@ -2056,11 +2056,9 @@ restore_fpu_state(CPUSPARCState *env, qemu_siginfo_fpu_t
*fpu)
return -EFAULT;
#endif
-#if 0
/* XXX: incorrect */
- err = __copy_from_user(&env->fpr[0], &fpu->si_float_regs[0],
- (sizeof(unsigned long) * 32));
-#endif
+ err = copy_from_user(&env->fpr[0], fpu->si_float_regs[0],
+ (sizeof(abi_ulong) * 32));
err |= __get_user(env->fsr, &fpu->si_fsr);
#if 0
err |= __get_user(current->thread.fpqdepth, &fpu->si_fpqdepth);
--
1.7.2.5
- [Qemu-devel] [PATCH v2 0/6] Clang patches, Blue Swirl, 2012/08/01
- [Qemu-devel] [PATCH v2 1/6] sparc: fix floppy TC line setup, Blue Swirl, 2012/08/01
- [Qemu-devel] [PATCH v2 2/6] sparc: fix expression with uninitialized initial value,
Blue Swirl <=
- [Qemu-devel] [PATCH v2 3/6] qapi: avoid reserved keywords, Blue Swirl, 2012/08/01
- [Qemu-devel] [PATCH v2 4/6] user: fix accidental AREG0 use, Blue Swirl, 2012/08/01
- [Qemu-devel] [PATCH v2 6/6] scsi-bus: remove overlapping entry, Blue Swirl, 2012/08/01
- [Qemu-devel] [PATCH v2 5/6] xilinx_axienet: avoid useless self-assignment, Blue Swirl, 2012/08/01