[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH V4 08/12] hw/sd.c: add SD card save/load support
|
From: |
Peter Maydell |
|
Subject: |
Re: [Qemu-devel] [PATCH V4 08/12] hw/sd.c: add SD card save/load support |
|
Date: |
Tue, 31 Jul 2012 15:56:38 +0100 |
On 27 July 2012 20:29, Igor Mitsyanko <address@hidden> wrote:
> + VMSTATE_BUFFER_MULTIPLY(wp_groups, SDState, 1, NULL, 0, wpgrps_size,
> + sizeof(unsigned long)),
Isn't this trying to use wpgrps_size as the number of unsigned longs in
the bitmap, when it's actually the size of the bitmap in bits?
(Does this correctly work in migration between 32 and 64 bit systems
where 'unsigned long' is a different size? How about between a little
endian 32 bit system and a big endian 64 bit system? I don't know
enough about the vmstate macros to be confident here...)
-- PMM
- Re: [Qemu-devel] [PATCH V4 09/12] hw/sd.c: convert SD state to QOM object, (continued)
[Qemu-devel] [PATCH V4 06/12] hw/sd.c: make sd_dataready() return bool, Igor Mitsyanko, 2012/07/27
[Qemu-devel] [PATCH V4 11/12] SD card: introduce "spi" property for SD card objects, Igor Mitsyanko, 2012/07/27
[Qemu-devel] [PATCH V4 08/12] hw/sd.c: add SD card save/load support, Igor Mitsyanko, 2012/07/27
[Qemu-devel] [PATCH V4 10/12] SD card users: optimize access to SDClass methods, Igor Mitsyanko, 2012/07/27
[Qemu-devel] [PATCH V4 07/12] hw/sd.c: make sd_wp_addr() return bool, Igor Mitsyanko, 2012/07/27