[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] Makefile: Avoid explicit list of directories in
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH] Makefile: Avoid explicit list of directories in clean target |
Date: |
Tue, 31 Jul 2012 08:24:58 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:14.0) Gecko/20120717 Thunderbird/14.0 |
On 07/31/2012 08:19 AM, Markus Armbruster wrote:
> Peter Maydell <address@hidden> writes:
>
>> Avoid having an explicit list of directories in the 'clean'
>> target by using 'find' to remove all .o and .d files instead.
>>
>> rm -f qemu-options.def
>> - rm -f *.o *.d *.a *.lo $(TOOLS) $(HELPERS-y) qemu-ga TAGS cscope.*
>> *.pod *~ */*~
>> + find . -name '*.[od]' | xargs rm -f
>> + rm -f *.a *.lo $(TOOLS) $(HELPERS-y) qemu-ga TAGS cscope.* *.pod *~ */*~
>
> Shit happens if you somehow manage to create a "mean" file name in the
> build tree. Sure you don't want to -print0 | xargs -0?
Except that 'find -print0' and 'xargs -0' are both GNU extensions, not
available everywhere. We may be requiring gmake and gcc, but are we
also requiring GNU find?
The POSIX way to write this, without relying on extensions, is:
find . -name '*.[od]' -exec rm -f {} +
(although then you get into the arguments of whether 'find -exec {} +'
is portable yet, even though it has now been required by POSIX for more
than 4 years.)
--
Eric Blake address@hidden +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH] Makefile: Avoid explicit list of directories in clean target, (continued)
- Re: [Qemu-devel] [PATCH] Makefile: Avoid explicit list of directories in clean target, Stefan Hajnoczi, 2012/07/31
- Re: [Qemu-devel] [PATCH] Makefile: Avoid explicit list of directories in clean target, Markus Armbruster, 2012/07/31
- Re: [Qemu-devel] [PATCH] Makefile: Avoid explicit list of directories in clean target, Peter Maydell, 2012/07/31
- Re: [Qemu-devel] [PATCH] Makefile: Avoid explicit list of directories in clean target, Markus Armbruster, 2012/07/31
- Re: [Qemu-devel] [PATCH] Makefile: Avoid explicit list of directories in clean target, Daniel P. Berrange, 2012/07/31
- Re: [Qemu-devel] [PATCH] Makefile: Avoid explicit list of directories in clean target, Peter Maydell, 2012/07/31
- Re: [Qemu-devel] [PATCH] Makefile: Avoid explicit list of directories in clean target, Stefan Weil, 2012/07/31
- Re: [Qemu-devel] [PATCH] Makefile: Avoid explicit list of directories in clean target, Peter Maydell, 2012/07/31
- Re: [Qemu-devel] [PATCH] Makefile: Avoid explicit list of directories in clean target, Stefan Weil, 2012/07/31
- Re: [Qemu-devel] [PATCH] Makefile: Avoid explicit list of directories in clean target, Blue Swirl, 2012/07/31
Re: [Qemu-devel] [PATCH] Makefile: Avoid explicit list of directories in clean target,
Eric Blake <=