[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 0/2] net: Make -netdev socket,listen= work
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH 0/2] net: Make -netdev socket,listen= work |
Date: |
Tue, 31 Jul 2012 14:31:42 +0100 |
On Fri, Jul 20, 2012 at 2:25 PM, Stefan Hajnoczi
<address@hidden> wrote:
> The socket backend does not support the listen= option with -netdev. The
> problem is how the socket NetClientState lifecycle is implemented: the socket
> backend waits for an incoming client connection before creating a
> NetClientState. The guest -device wants a peer= on startup, so QEMU fails
> with
> an error about the non-existent peer.
>
> This series makes -netdev socket,listen= work by creating the NetClientState
> right away. This allows -device peer= to find the socket backend.
>
> This code was written by Zhi Yong Wu <address@hidden>. I have only
> cleaned up and tested it. The following work:
> * -net socket,listen=:1234 -net nic,model=virtio
> * -netdev socket,listen=:1234,id=netdev0 -device
> virtio-net-pci,netdev=netdev0
>
> Zhi Yong Wu (2):
> net: fix the coding style
> net: add the support for -netdev socket, listen
>
> net/socket.c | 82
> +++++++++++++++++++++++++++++++++++-----------------------
> 1 file changed, 50 insertions(+), 32 deletions(-)
Merged into the net tree:
https://github.com/stefanha/qemu/tree/net
Stefan