[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 01/32] megasas: Replace trace_megasas_dcmd_dump_
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH 01/32] megasas: Replace trace_megasas_dcmd_dump_frame() |
Date: |
Mon, 30 Jul 2012 10:40:49 +0100 |
On Fri, Jul 27, 2012 at 4:02 PM, Paolo Bonzini <address@hidden> wrote:
> From: Hannes Reinecke <address@hidden>
>
> trace_megasas_dcmd_dump_frame() takes 9 arguments, which is
> rather much. Plus the trace infrastructure doesn't support
> it. As we can get the information via other means it's pointless
> to have it in the driver, so rather use some proper trace
> point here and remove the old one.
>
> Signed-off-by: Hannes Reinecke <address@hidden>
> Cc: Stefan Weil <address@hidden>
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
> hw/megasas.c | 39 ++++++++++-----------------------------
> trace-events | 2 +-
> 2 files changed, 11 insertions(+), 30 deletions(-)
The simple trace backend now supports arbitrary argument counts :).
I don't think you need to change this patch but I'm just spreading the
word since this limitation has now been lifted.
Stefan
- [Qemu-devel] [PULL 00/32] SCSI patches for 2012-08-27, Paolo Bonzini, 2012/07/27
- [Qemu-devel] [PATCH 03/32] lsi: use qdev_reset_all, Paolo Bonzini, 2012/07/27
- [Qemu-devel] [PATCH 02/32] megasas: fix misuse of scsi_req_abort, Paolo Bonzini, 2012/07/27
- [Qemu-devel] [PATCH 01/32] megasas: Replace trace_megasas_dcmd_dump_frame(), Paolo Bonzini, 2012/07/27
- Re: [Qemu-devel] [PATCH 01/32] megasas: Replace trace_megasas_dcmd_dump_frame(),
Stefan Hajnoczi <=
- [Qemu-devel] [PATCH 05/32] lsi: avoid redundant tests of s->current != NULL, Paolo Bonzini, 2012/07/27
- [Qemu-devel] [PATCH 06/32] scsi-block: remove properties that are not relevant for passthrough, Paolo Bonzini, 2012/07/27
- [Qemu-devel] [PATCH 04/32] lsi: introduce lsi_request_free, Paolo Bonzini, 2012/07/27
- [Qemu-devel] [PATCH 09/32] scsi-disk: make discard asynchronous, Paolo Bonzini, 2012/07/27
- [Qemu-devel] [PATCH 07/32] cutils: add strpadcpy(), Paolo Bonzini, 2012/07/27
- [Qemu-devel] [PATCH 10/32] scsi-disk: move all non-DMA commands to scsi_disk_emulate_command, Paolo Bonzini, 2012/07/27
- [Qemu-devel] [PATCH 11/32] scsi-disk: split scsi-disk reqops, Paolo Bonzini, 2012/07/27
- [Qemu-devel] [PATCH 13/32] scsi-disk: support emulated TO_DEV requests, Paolo Bonzini, 2012/07/27
- [Qemu-devel] [PATCH 08/32] scsi-disk: let the user customize vendor and product name, Paolo Bonzini, 2012/07/27
- [Qemu-devel] [PATCH 14/32] scsi-disk: adjust offsets in MODE SENSE by 2, Paolo Bonzini, 2012/07/27