[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/5] qom: adopt rwlock to protect accessing dev
From: |
Avi Kivity |
Subject: |
Re: [Qemu-devel] [PATCH 1/5] qom: adopt rwlock to protect accessing dev from removing it |
Date: |
Thu, 26 Jul 2012 16:00:52 +0300 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120615 Thunderbird/13.0.1 |
On 07/26/2012 03:56 PM, liu ping fan wrote:
> On Wed, Jul 25, 2012 at 5:08 PM, Paolo Bonzini <address@hidden> wrote:
>> Il 25/07/2012 05:31, Liu Ping Fan ha scritto:
>>> From: Liu Ping Fan <address@hidden>
>>>
>>> rwlock:
>>> qemu_device_tree_mutex
>>>
>>> rd side:
>>> --device_del(destruction of device will be postphoned until unplug
>>> ack from guest),
>>> --pci hot-unplug
>>> --iteration (qdev_reset_all)
>>>
>>> wr side:
>>> --device_add
>>>
>>
>> This is not defined anywhere, is a piece missing in the patch?
>>
> Oh, yes, I miss the patch. In that patch, these rwlock are just place holder.
> I see there is already try to implement rwlock for qemu.
> http://lists.gnu.org/archive/html/qemu-devel/2011-10/msg00192.html
> and is it the time for introduce rwlock for qemu?
>From the description above, I don't see why it can't be a mutex.
--
error compiling committee.c: too many arguments to function
- [Qemu-devel] [PATCH 0/5] prepare unplug out of protection of global lock, Liu Ping Fan, 2012/07/24
- [Qemu-devel] [PATCH 1/5] qom: adopt rwlock to protect accessing dev from removing it, Liu Ping Fan, 2012/07/24
- Re: [Qemu-devel] [PATCH 1/5] qom: adopt rwlock to protect accessing dev from removing it, Paolo Bonzini, 2012/07/25
- Re: [Qemu-devel] [PATCH 1/5] qom: adopt rwlock to protect accessing dev from removing it, liu ping fan, 2012/07/26
- Re: [Qemu-devel] [PATCH 1/5] qom: adopt rwlock to protect accessing dev from removing it,
Avi Kivity <=
- Re: [Qemu-devel] [PATCH 1/5] qom: adopt rwlock to protect accessing dev from removing it, liu ping fan, 2012/07/26
- Re: [Qemu-devel] [PATCH 1/5] qom: adopt rwlock to protect accessing dev from removing it, Avi Kivity, 2012/07/26
- Re: [Qemu-devel] [PATCH 1/5] qom: adopt rwlock to protect accessing dev from removing it, liu ping fan, 2012/07/26
- Re: [Qemu-devel] [PATCH 1/5] qom: adopt rwlock to protect accessing dev from removing it, Avi Kivity, 2012/07/26
[Qemu-devel] [PATCH 2/5] exec.c: use refcnt to protect device during dispatching, Liu Ping Fan, 2012/07/24
Re: [Qemu-devel] [PATCH 2/5] exec.c: use refcnt to protect device during dispatching, Avi Kivity, 2012/07/25