[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/2] qemu-opts: introduce a function to compare
From: |
Anthony Liguori |
Subject: |
Re: [Qemu-devel] [PATCH 1/2] qemu-opts: introduce a function to compare option names |
Date: |
Wed, 25 Jul 2012 12:34:42 -0500 |
User-agent: |
Notmuch/0.13.2+93~ged93d79 (http://notmuchmail.org) Emacs/23.3.1 (x86_64-pc-linux-gnu) |
Eric Blake <address@hidden> writes:
> On 07/25/2012 10:45 AM, Eric Blake wrote:
>> On 07/25/2012 10:25 AM, Anthony Liguori wrote:
>>> We don't use the standard C functions for conversion because we don't want
>>> to
>>> depend on the user's locale. All option names in QEMU are en_US in plain
>>> ASCII.
>>
>>>
>>> +static int opt_tolower(int ch)
>>> +{
>>> + if (ch >= 'A' && ch <= 'Z') {
>>> + return 'a' + (ch - 'A');
>
> P.S. This is not portable to EBCDIC, but I guess we don't care about
> compilation of qemu on a non-ASCII machine, so my review still stands.
Fortunately, even on S390, Linux uses ASCII under normal circumstances
:-)
Regards,
Anthony Liguori
>
>> Reviewed-by: Eric Blake <address@hidden>
>>
>
> --
> Eric Blake address@hidden +1-919-301-3266
> Libvirt virtualization library http://libvirt.org
- Re: [Qemu-devel] [PATCH 2/2] qemu-config: convert all QemuOpts to use dashes instead of underscores, (continued)
- Re: [Qemu-devel] [PATCH 2/2] qemu-config: convert all QemuOpts to use dashes instead of underscores, Peter Maydell, 2012/07/25
- Re: [Qemu-devel] [PATCH 2/2] qemu-config: convert all QemuOpts to use dashes instead of underscores, Luiz Capitulino, 2012/07/25
- Re: [Qemu-devel] [PATCH 2/2] qemu-config: convert all QemuOpts to use dashes instead of underscores, Peter Maydell, 2012/07/25
- [Qemu-devel] Changing qemu's -help output, Luiz Capitulino, 2012/07/25
- Re: [Qemu-devel] [libvirt] Changing qemu's -help output, Eric Blake, 2012/07/25
- Re: [Qemu-devel] [PATCH 2/2] qemu-config: convert all QemuOpts to use dashes instead of underscores, Markus Armbruster, 2012/07/27
Re: [Qemu-devel] [PATCH 2/2] qemu-config: convert all QemuOpts to use dashes instead of underscores, Andreas Färber, 2012/07/27
[Qemu-devel] [PATCH 1/2] qemu-opts: introduce a function to compare option names, Anthony Liguori, 2012/07/25
Re: [Qemu-devel] [PATCH 1/2] qemu-opts: introduce a function to compare option names, Peter Maydell, 2012/07/25
Re: [Qemu-devel] [PATCH 1/2] qemu-opts: introduce a function to compare option names, Markus Armbruster, 2012/07/27
Re: [Qemu-devel] [PATCH 0/2] Allow '-' or '_' for all QemuOpts, Luiz Capitulino, 2012/07/25
Re: [Qemu-devel] [PATCH 0/2] Allow '-' or '_' for all QemuOpts, Markus Armbruster, 2012/07/27