|
From: | Avi Kivity |
Subject: | Re: [Qemu-devel] [PATCH 3/5] hotplug: introduce qdev_unplug_ack() to remove device from views |
Date: | Wed, 25 Jul 2012 13:58:48 +0300 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120615 Thunderbird/13.0.1 |
On 07/25/2012 06:31 AM, Liu Ping Fan wrote: > From: Liu Ping Fan <address@hidden> > > When guest confirm the removal of device, we should > --unmap from MemoryRegion view > --isolated from device tree view > > + > +void qdev_unplug_ack(DeviceState *dev, Error **errp) > +{ > + qemu_rwlock_wrlock_devtree(); > + /* isolate from device tree */ > + qdev_unset_parent(dev); > + /* isolate from mem view */ > + qdev_unmap(dev); > + qemu_rwlock_unlock_devtree(); > + object_unref(OBJECT(dev)); > +} Suggest calling in _complete() instead. -- error compiling committee.c: too many arguments to function
[Prev in Thread] | Current Thread | [Next in Thread] |