qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 2/2] build: get dependency file directories from


From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH 2/2] build: get dependency file directories from object file names
Date: Tue, 24 Jul 2012 13:43:00 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120615 Thunderbird/13.0.1

Il 24/07/2012 13:38, Andreas Färber ha scritto:
>> > +$(foreach var,$(nested-vars), $(eval \
>> > +  -include $(addsuffix *.d, $(sort $(dir $($(var)))))))
>> >  endef
>> > 
> Are you sure? Dependencies are not guaranteed to be in one of the
> unnested variables, thought we ran into some issues earlier... In
> particular I'm thinking of tcg/*.d and of *.d in .user, .target, those
> that are actually recursed into.

obj-y is a nested variable:

  nested-vars += obj-y

  # This resolves all nested paths, so it must come last
  include $(SRC_PATH)/Makefile.objs

$(dir $(obj-y)) contains tcg/ and from there you get tcg/*.d.

The only makefile that doesn't use the nesting mechanism is tests/Makefile.

Paolo




reply via email to

[Prev in Thread] Current Thread [Next in Thread]