Re: [Qemu-devel] [PATCH] update-linux-headers.sh: Don't hard code list of architectures

[Jan Kiszka]

On 2012-07-18 12:11, Peter Maydell wrote:
> Rather than hardcoding the list of architectures in the kernel
> header update script, just import headers for every architecture
> which supports KVM (with a blacklist exception for ia64 which
> has KVM headers but is dead). This reduces the number of QEMU
> files which need to be updated to add support for a new KVM
> architecture.
> 
> Signed-off-by: Peter Maydell <address@hidden>

Acked-by: Jan Kiszka <address@hidden>

> ---
> Changes v1->v2:
>  * added a blacklist for ia64, to avoid noise and importing
>    a pointless set of headers that will get dropped later
> 
>  scripts/update-linux-headers.sh |   16 +++++++++++++++-
>  1 files changed, 15 insertions(+), 1 deletions(-)
> 
> diff --git a/scripts/update-linux-headers.sh b/scripts/update-linux-headers.sh
> index 9d2a4bc..57ce69f 100755
> --- a/scripts/update-linux-headers.sh
> +++ b/scripts/update-linux-headers.sh
> @@ -28,7 +28,21 @@ if [ -z "$output" ]; then
>      output="$PWD"
>  fi
>  
> -for arch in x86 powerpc s390; do
> +# This will pick up non-directories too (eg "Kconfig") but we will
> +# ignore them in the next loop.
> +ARCHLIST=$(cd "$linux/arch" && echo *)
> +
> +for arch in $ARCHLIST; do
> +    # Discard anything which isn't a KVM-supporting architecture
> +    if ! [ -e "$linux/arch/$arch/include/asm/kvm.h" ]; then
> +        continue
> +    fi
> +
> +    # Blacklist architectures which have KVM headers but are actually dead
> +    if [ "$arch" = "ia64" ]; then
> +        continue
> +    fi
> +
>      make -C "$linux" INSTALL_HDR_PATH="$tmpdir" SRCARCH=$arch headers_install
>  
>      rm -rf "$output/linux-headers/asm-$arch"
> 


-- 
Siemens AG, Corporate Technology, CT RTC ITP SDP-DE
Corporate Competence Center Embedded Linux