qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] configure: fix ALSA configure test


From: Igor Mitsyanko
Subject: Re: [Qemu-devel] [PATCH] configure: fix ALSA configure test
Date: Tue, 17 Jul 2012 22:03:48 +0400
User-agent: Mozilla/5.0 (X11; Linux i686; rv:13.0) Gecko/20120615 Thunderbird/13.0.1

I see now that this bug was already noticed, please ignore this mail

On 07/17/2012 09:34 PM, Igor Mitsyanko wrote:
After commit 417c9d72d48275d19c60861896efd4962d21aca2 all configure tests are
executed with -Werror flag. Current ALSA configure test program invokes a 
warning:

warning: ‘handle’ is used uninitialized in this function [-Wuninitialized]

which results in error with -Werror flag and, consequently, in alsa test 
failing.
This means that QEMU won't configure with "--audio-drv-list=alsa".

Initialize "handle" variable to fix compilation warning.

Signed-off-by: Igor Mitsyanko <address@hidden>
---
  configure |    2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/configure b/configure
index 0a3896e..cf4669f 100755
--- a/configure
+++ b/configure
@@ -1888,7 +1888,7 @@ for drv in $audio_drv_list; do
      case $drv in
      alsa)
      audio_drv_probe $drv alsa/asoundlib.h -lasound \
-        "snd_pcm_t **handle; return snd_pcm_close(*handle);"
+        "snd_pcm_t *handle = 0; return snd_pcm_close(handle);"
      libs_softmmu="-lasound $libs_softmmu"
      ;;








reply via email to

[Prev in Thread] Current Thread [Next in Thread]