Re: [Qemu-devel] [RFC PATCH 25/36] mirror: add support for on_source_error/on_target_error

[Paolo Bonzini]

Il 15/06/2012 23:12, Eric Blake ha scritto:
>> > +#
>> >  # Returns: nothing on success
>> >  #          If @device is not a valid block device, DeviceNotFound
>> >  #          If @target can't be opened, OpenFileFailed
>> > @@ -1389,7 +1393,8 @@
>> >  { 'command': 'drive-mirror',
>> >    'data': { 'device': 'str', 'target': 'str', '*format': 'str',
>> >              'sync': 'MirrorSyncMode', '*mode': 'NewImageMode',
>> > -            '*speed': 'int' } }
>> > +            '*speed': 'int', '*on_source_error': 'BlockdevOnError',
>> > +            '*on_target_error': 'BlockdevOnError' } }
> QMP should prefer - over _; shouldn't this be '*on-source-error' and
> '*on-target-error'?

Will fix.

Paolo