[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v3 29/29] Relax IDE CHS limits from 16383, 16, 63 to
From: |
Markus Armbruster |
Subject: |
[Qemu-devel] [PATCH v3 29/29] Relax IDE CHS limits from 16383, 16, 63 to 65535, 16, 255 |
Date: |
Tue, 10 Jul 2012 11:12:55 +0200 |
New limits straight from ATA4 6.2 Register delivered data transfer
command sector addressing.
I figure the old sector limit 63 was blindly copied from the BIOS
int 13 limit. Doesn't apply to the hardware. No idea where the old
cylinder limit comes from.
Signed-off-by: Markus Armbruster <address@hidden>
---
hw/ide/core.c | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/hw/ide/core.c b/hw/ide/core.c
index 1ca7cdf..58a454f 100644
--- a/hw/ide/core.c
+++ b/hw/ide/core.c
@@ -1935,16 +1935,16 @@ int ide_init_drive(IDEState *s, BlockDriverState *bs,
IDEDriveKind kind,
s->drive_kind = kind;
bdrv_get_geometry(bs, &nb_sectors);
- if (cylinders < 1 || cylinders > 16383) {
- error_report("cyls must be between 1 and 16383");
+ if (cylinders < 1 || cylinders > 65535) {
+ error_report("cyls must be between 1 and 65535");
return -1;
}
if (heads < 1 || heads > 16) {
error_report("heads must be between 1 and 16");
return -1;
}
- if (secs < 1 || secs > 63) {
- error_report("secs must be between 1 and 63");
+ if (secs < 1 || secs > 255) {
+ error_report("secs must be between 1 and 255");
return -1;
}
s->cylinders = cylinders;
--
1.7.6.5
- [Qemu-devel] [PATCH v3 07/29] hd-geometry: Unnest conditional in hd_geometry_guess(), (continued)
- [Qemu-devel] [PATCH v3 07/29] hd-geometry: Unnest conditional in hd_geometry_guess(), Markus Armbruster, 2012/07/10
- [Qemu-devel] [PATCH v3 14/29] qdev: Introduce block geometry properties, Markus Armbruster, 2012/07/10
- [Qemu-devel] [PATCH v3 15/29] hd-geometry: Switch to uint32_t to match BlockConf, Markus Armbruster, 2012/07/10
- [Qemu-devel] [PATCH v3 12/29] ide pc: Cut out the block layer geometry middleman, Markus Armbruster, 2012/07/10
- [Qemu-devel] [PATCH v3 21/29] qdev: New property type chs-translation, Markus Armbruster, 2012/07/10
- [Qemu-devel] [PATCH v3 13/29] blockdev: Save geometry in DriveInfo, Markus Armbruster, 2012/07/10
- [Qemu-devel] [PATCH v3 18/29] ide: qdev properties for disk geometry, Markus Armbruster, 2012/07/10
- [Qemu-devel] [PATCH v3 16/29] scsi-hd: qdev properties for disk geometry, Markus Armbruster, 2012/07/10
- [Qemu-devel] [PATCH v3 17/29] virtio-blk: qdev properties for disk geometry, Markus Armbruster, 2012/07/10
- [Qemu-devel] [PATCH v3 19/29] qtest: Cover qdev properties for disk geometry, Markus Armbruster, 2012/07/10
- [Qemu-devel] [PATCH v3 29/29] Relax IDE CHS limits from 16383, 16, 63 to 65535, 16, 255,
Markus Armbruster <=
- [Qemu-devel] [PATCH v3 27/29] hd-geometry: Compute BIOS CHS translation in one place, Markus Armbruster, 2012/07/10
- [Qemu-devel] [PATCH v3 05/29] hd-geometry: Move disk geometry guessing back from block.c, Markus Armbruster, 2012/07/10
- [Qemu-devel] [PATCH v3 23/29] qtest: Cover qdev property for BIOS CHS translation, Markus Armbruster, 2012/07/10
- [Qemu-devel] [PATCH v3 24/29] block: Geometry and translation hints are now useless, purge them, Markus Armbruster, 2012/07/10
- [Qemu-devel] [PATCH v3 22/29] ide: qdev property for BIOS CHS translation, Markus Armbruster, 2012/07/10
- [Qemu-devel] [PATCH v3 28/29] blockdev: Drop redundant CHS validation for if=ide, Markus Armbruster, 2012/07/10
- [Qemu-devel] [PATCH v3 26/29] qtest: Test we don't put hard disk info into CMOS for a CD-ROM, Markus Armbruster, 2012/07/10
- [Qemu-devel] [PATCH v3 25/29] ide pc: Put hard disk info into CMOS only for hard disks, Markus Armbruster, 2012/07/10