qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 3/3] bitops: use bool


From: Markus Armbruster
Subject: Re: [Qemu-devel] [PATCH v2 3/3] bitops: use bool
Date: Mon, 09 Jul 2012 09:43:30 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3 (gnu/linux)

address@hidden writes:

> From: Blue Swirl <address@hidden>
>
> Use 'bool' type for return value of bit test functions.

Matter of taste.  'bool' makes sense if you think of these functions as
predicates (ugly ones, with side effects).  'int' makes sense if you
think of them as returning the bit value (a bit is not a truth value in
my book).

In my opinion, this is just unnecessary churn, and unnecessary deviation
from established kernel practice.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]