[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 4/6] qapi: generate list struct and visit_lis
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v4 4/6] qapi: generate list struct and visit_list for enum |
Date: |
Thu, 05 Jul 2012 07:01:23 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120615 Thunderbird/13.0.1 |
On 07/05/2012 06:48 AM, Amos Kong wrote:
> Currently, if define an 'enum' and use it in one command's data,
> List struct for enum could not be generated, but it's used in
> qmp function.
>
> For example: KeyCodesList could not be generated.
>>>> qapi-schema.json:
> { 'enum': 'KeyCodes',
> 'data': [ 'shift', 'alt' ... ] }
> { 'command': 'sendkey',
> 'data': { 'keys': ['KeyCodes'], '*hold-time': 'int' } }
>
>>>> qmp-command.h:
> void qmp_sendkey(KeyCodesList * keys, bool has_hold_time, int64_t
> hold_time, Error **errp);
>
> This patch makes qapi can generate List struct for enum.
Grammar nit:
s/makes qapi can/lets/qapi/
--
Eric Blake address@hidden +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v4 0/6] convert sendkey to qapi, Amos Kong, 2012/07/05
- [Qemu-devel] [PATCH v4 1/6] fix doc of using raw values with sendkey, Amos Kong, 2012/07/05
- [Qemu-devel] [PATCH v4 3/6] hmp: rename arguments, Amos Kong, 2012/07/05
- [Qemu-devel] [PATCH v4 2/6] monitor: rename keyname '<' to 'less', Amos Kong, 2012/07/05
- [Qemu-devel] [PATCH v4 4/6] qapi: generate list struct and visit_list for enum, Amos Kong, 2012/07/05
- Re: [Qemu-devel] [PATCH v4 4/6] qapi: generate list struct and visit_list for enum,
Eric Blake <=
- [Qemu-devel] [PATCH v4 6/6] ps2: output warning when event queue full, Amos Kong, 2012/07/05
- [Qemu-devel] [PATCH v4 5/6] qapi: convert sendkey, Amos Kong, 2012/07/05
- Re: [Qemu-devel] [PATCH v4 5/6] qapi: convert sendkey, Amos Kong, 2012/07/25
- Re: [Qemu-devel] [PATCH v4 5/6] qapi: convert sendkey, Luiz Capitulino, 2012/07/25
- Re: [Qemu-devel] [PATCH v4 5/6] qapi: convert sendkey, Amos Kong, 2012/07/25