Re: [Qemu-devel] [PATCH] console: Implementing blinking of cursor

[Stefan Weil]

Am 02.07.2012 10:20, schrieb Jan Kiszka:
> Let the text console cursor blink at 5 HZ.
>
> Signed-off-by: Jan Kiszka <address@hidden>
> ---
> console.c | 26 +++++++++++++++++++++++++-
> 1 files changed, 25 insertions(+), 1 deletions(-)

Hi Jan,

I know that there was a "bug" report. Nevertheless I'd like
to ask whether QEMU really needs a blinking text cursor.

Blinking cursors are a matter of taste. I personally don't
want a blinking cursors. Nor do I want programs which
wake my cpu 5 times a second for something which I
don't need.

It's possible to get a blinking cursor without your patch
by redirecting QEMU's text console to one of the common
X terminal emulations (xterm, konsole, ...).

When QEMU gets GTK support, it might use a terminal
emulation which allows configurable cursor blinking.
IMHO that would be better than implementing that feature
in QEMU code.

That's why I suggest not to apply the patch.

Cheers,

Stefan