[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/2] virtio-blk: disable write cache if not nego
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PATCH 2/2] virtio-blk: disable write cache if not negotiated |
Date: |
Tue, 03 Jul 2012 15:49:48 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120605 Thunderbird/13.0 |
Am 03.07.2012 15:20, schrieb Paolo Bonzini:
> If the guest does not support flushes, we should run in writethrough mode.
> The setting is temporary until the next reset, so that for example the
> BIOS will run in writethrough mode while Linux will run with a writeback
> cache.
>
> VIRTIO_BLK_F_FLUSH has been introduced in Linux 2.6.32 (in 2009) and
> was backported to RHEL/CentOS 5.6 (in 2010). The Windows drivers have
> two bugs, which I reported on the Red Hat Bugzilla as bugs 837321 and
> 837324. With these patches they will suffer a performance hit but
> gain correctness.
>
> Signed-off-by: Paolo Bonzini <address@hidden>
I generally like the idea for a default, but doesn't this override even
an explicit cache=writeback? Are we sure that we want this?
Kevin
- [Qemu-devel] [QEMU PATCH 0/2] virtio-blk: writeback cache enable improvements, Paolo Bonzini, 2012/07/03
- [Qemu-devel] [PATCH 1/2] virtio-blk: support VIRTIO_BLK_F_CONFIG_WCE, Paolo Bonzini, 2012/07/03
- [Qemu-devel] [PATCH 2/2] virtio-blk: disable write cache if not negotiated, Paolo Bonzini, 2012/07/03
- Re: [Qemu-devel] [PATCH 2/2] virtio-blk: disable write cache if not negotiated,
Kevin Wolf <=
- Re: [Qemu-devel] [PATCH 2/2] virtio-blk: disable write cache if not negotiated, Paolo Bonzini, 2012/07/03
- Re: [Qemu-devel] [PATCH 2/2] virtio-blk: disable write cache if not negotiated, Kevin Wolf, 2012/07/04
- Re: [Qemu-devel] [PATCH 2/2] virtio-blk: disable write cache if not negotiated, Paolo Bonzini, 2012/07/04
- Re: [Qemu-devel] [PATCH 2/2] virtio-blk: disable write cache if not negotiated, Kevin Wolf, 2012/07/04
- Re: [Qemu-devel] [PATCH 2/2] virtio-blk: disable write cache if not negotiated, Paolo Bonzini, 2012/07/04
Re: [Qemu-devel] [QEMU PATCH 0/2] virtio-blk: writeback cache enable improvements, Paolo Bonzini, 2012/07/23