Re: [Qemu-devel] [PATCH v4 3/7] qapi: Add pass-fd QMP command

[Corey Bryant]

On 06/25/2012 11:34 AM, Kevin Wolf wrote:
> Am 25.06.2012 16:51, schrieb Corey Bryant:
> > Thanks for catching this.  I'll fix this in v5.  In terms of platforms
> > that support dup3 vs dup2, I'm assuming the following preprocessor
> > checks will do what we need:
> >
> > #if defined(__linux__) || defined(__CYGWIN__)
> > dup3(fd, monfd->fd, O_CLOEXEC)
> > #else
> > dup2()+fcntl(F_GETFD/F_SETFD)
> > #endif
>
> Checking for dup3() in configure might be the better option. It's not
> like it has been there forever, even on Linux.
>
> Kevin

Ah, thanks. It looks like support is already there and I can just check:
#if defined(CONFIG_DUP3)

--
Regards,
Corey