Re: [Qemu-devel] [PATCH] Exynos4: added RTC device

[Andreas Färber]

Am 25.06.2012 09:55, schrieb Oleg Ogurtsov:
> Signed-off-by: Oleg Ogurtsov <address@hidden>
> ---
>  hw/arm/Makefile.objs |    1 +
>  hw/exynos4210.c      |    8 +
>  hw/exynos4210_rtc.c  |  607 
> ++++++++++++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 616 insertions(+), 0 deletions(-)
>  create mode 100644 hw/exynos4210_rtc.c

This RTC like many other Exynos devices has no dependency on the CPU. I
have a patch in preparation that moves such devices from
hw/arm/Makefile.objs to hw/Makefile.objs.
I don't object to this patch, not even minor style nits spotted,
compliment, but if you have to respin for some reason, it would be nice
if you could consider that improvement.

One thing I noted though, is it time to share the static BCD conversion
helpers used in the various RTCs? (bcd.c? qemu-common.h?) Or are they
slightly different?

Regards,
Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg