Re: [Qemu-devel] [PATCH 04/13] usb-ohci: Use universal DMA helper functions

[Benjamin Herrenschmidt]

On Thu, 2012-06-21 at 07:55 -0500, Anthony Liguori wrote:

> As long as we scrub the buffers, returning an unhandled error seems okay to 
> me.
> 
> I've long thought we should have some sort of generic way to throw an error 
> and 
> effectively pause a single device.  I'm not sure how it would work in 
> practice 
> though.

I'll scrub the buffer in dma_memory_rw when reading from the guest in
all failure cases to ensure that we don't use a buffer of stale qemu
data.

In addition I'm doing a separate patch that I'll post later (needs a bit
more time) that improves OHCI's error handling.

Cheers,
Ben.