[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/3] iommu: remove extra 'typedef struct DMACont
From: |
Benjamin Herrenschmidt |
Subject: |
Re: [Qemu-devel] [PATCH 1/3] iommu: remove extra 'typedef struct DMAContext' |
Date: |
Fri, 22 Jun 2012 12:02:35 +1000 |
On Wed, 2012-06-20 at 16:11 -0400, Jason Baron wrote:
> There are several instances of 'typedef struct DMAContext DMAContext'. Remove
> them
> all except for the one in qemu-common.h.
Actually, the other way around :-) I'm removing the one in qemu-common.h
in favor of the one in dma.h (at Anthony's request). I'll have a new
series soon...
Cheers,
Ben.
> Signed-off-by: Jason Baron <address@hidden>
> ---
> dma.h | 5 ++---
> 1 files changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/dma.h b/dma.h
> index 0d57e50..862373d 100644
> --- a/dma.h
> +++ b/dma.h
> @@ -15,7 +15,6 @@
> #include "block.h"
> #include "kvm.h"
>
> -typedef struct DMAContext DMAContext;
> typedef struct ScatterGatherEntry ScatterGatherEntry;
>
> typedef enum {
> @@ -65,11 +64,11 @@ typedef void DMAUnmapFunc(DMAContext *dma,
> DMADirection dir,
> dma_addr_t access_len);
>
> -typedef struct DMAContext {
> +struct DMAContext {
> DMATranslateFunc *translate;
> DMAMapFunc *map;
> DMAUnmapFunc *unmap;
> -} DMAContext;
> +};
>
> static inline void dma_barrier(DMAContext *dma, DMADirection dir)
> {