[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] Remove support for non-threaded VNC server
|
From: |
Gerd Hoffmann |
|
Subject: |
Re: [Qemu-devel] [PATCH] Remove support for non-threaded VNC server |
|
Date: |
Thu, 21 Jun 2012 12:23:48 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:10.0.5) Gecko/20120601 Thunderbird/10.0.5 |
On 06/21/12 11:59, Daniel P. Berrange wrote:
> On Thu, Jun 21, 2012 at 12:57:44PM +0300, Michael Tokarev wrote:
>> 20.06.2012 16:24, Daniel P. Berrange wrote:
>>> delete mode 100644 ui/vnc-jobs-async.c
>>> delete mode 100644 ui/vnc-jobs-sync.c
>>> create mode 100644 ui/vnc-jobs.c
>>
>> Is there a reason to rename vnc-jobs-foo.c to vnc-jobs.c ?
>
> The corresponding header file is vnc-jobs.h, and since we only
> have one impl of it now, using the same name is normal practice.
>
>> I'd leave it alone at this stage, omiting just the rename...
>
> I disagree, GIT handles renames like this fine, so there's no
> reason not to do this.
/me suggests "git format-patch -M" so the patch shows the rename.
cheers,
Gerd