Re: [Qemu-devel] [PATCH 02/13] Implement cpu_physical_memory_set()

[David Gibson]

On Wed, Jun 20, 2012 at 04:15:13PM -0500, Anthony Liguori wrote:
> On 06/19/2012 01:39 AM, Benjamin Herrenschmidt wrote:
> >From: David Gibson<address@hidden>
> >
> >This patch adds cpu_physical_memory_set() function.  This is equivalent to
> >calling cpu_physical_memory_write() with a buffer filled with a character,
> >ie, a memset of target memory.
> >
> >It uses a small temporary buffer on the stack.
> >
> >Signed-off-by: David Gibson<address@hidden>
> >Signed-off-by: Benjamin Herrenschmidt<address@hidden>
> 
> Why should this be in the core API?  Shouldn't this be a helper on
> top of the DMA API?

Well, I was hoping to avoid having to allocate a temporary buffer of
zeroes, which is necessary to do this in terms of the existing
cpu_physical_memory_write() api.

-- 
David Gibson                    | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au  | minimalist, thank you.  NOT _the_ _other_
                                | _way_ _around_!
http://www.ozlabs.org/~dgibson