[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 03/13] iommu: Add universal DMA helper functions
From: |
Michael S. Tsirkin |
Subject: |
Re: [Qemu-devel] [PATCH 03/13] iommu: Add universal DMA helper functions |
Date: |
Thu, 21 Jun 2012 00:40:03 +0300 |
On Wed, Jun 20, 2012 at 04:16:47PM -0500, Anthony Liguori wrote:
> >diff --git a/qemu-common.h b/qemu-common.h
> >index 8f87e41..80026af 100644
> >--- a/qemu-common.h
> >+++ b/qemu-common.h
> >@@ -264,6 +264,7 @@ typedef struct EventNotifier EventNotifier;
> > typedef struct VirtIODevice VirtIODevice;
> > typedef struct QEMUSGList QEMUSGList;
> > typedef struct SHPCDevice SHPCDevice;
> >+typedef struct DMAContext DMAContext;
>
> Please don't put this in qemu-common.h. Stick it in a dma-specific header.
Weird.
The point of typedefs in qemu-common.h is so people can
use type pointer *without pulling in the relevant header*.
If we put a typedef in specific header it defeats the purpose.
It used to even say this somewhere so I don't remember where.
--
MST
- Re: [Qemu-devel] [PATCH 09/13] iommu: Add facility to cancel in-use dma memory maps, (continued)
- [Qemu-devel] [PATCH 08/13] iommu: Introduce IOMMU emulation infrastructure, Benjamin Herrenschmidt, 2012/06/19
- [Qemu-devel] [PATCH 03/13] iommu: Add universal DMA helper functions, Benjamin Herrenschmidt, 2012/06/19
- Re: [Qemu-devel] [PATCH 03/13] iommu: Add universal DMA helper functions, Anthony Liguori, 2012/06/20
- Re: [Qemu-devel] [PATCH 03/13] iommu: Add universal DMA helper functions, Michael S. Tsirkin, 2012/06/20
- Re: [Qemu-devel] [PATCH 03/13] iommu: Add universal DMA helper functions, Anthony Liguori, 2012/06/20
- Re: [Qemu-devel] [PATCH 03/13] iommu: Add universal DMA helper functions, Michael S. Tsirkin, 2012/06/20
- Re: [Qemu-devel] [PATCH 03/13] iommu: Add universal DMA helper functions, Anthony Liguori, 2012/06/20
- Re: [Qemu-devel] [PATCH 03/13] iommu: Add universal DMA helper functions, Michael S. Tsirkin, 2012/06/20
- Re: [Qemu-devel] [PATCH 03/13] iommu: Add universal DMA helper functions, Benjamin Herrenschmidt, 2012/06/20
- Re: [Qemu-devel] [PATCH 03/13] iommu: Add universal DMA helper functions,
Michael S. Tsirkin <=
- Re: [Qemu-devel] [PATCH 03/13] iommu: Add universal DMA helper functions, Anthony Liguori, 2012/06/20
- Re: [Qemu-devel] [PATCH 03/13] iommu: Add universal DMA helper functions, David Gibson, 2012/06/20
- Re: [Qemu-devel] [PATCH 03/13] iommu: Add universal DMA helper functions, Benjamin Herrenschmidt, 2012/06/21
[Qemu-devel] [PATCH 07/13] usb: Convert usb_packet_{map, unmap} to universal DMA helpers, Benjamin Herrenschmidt, 2012/06/19
- Re: [Qemu-devel] [PATCH 07/13] usb: Convert usb_packet_{map, unmap} to universal DMA helpers, Gerd Hoffmann, 2012/06/19
- Re: [Qemu-devel] [PATCH 07/13] usb: Convert usb_packet_{map, unmap} to universal DMA helpers, Benjamin Herrenschmidt, 2012/06/19
- Re: [Qemu-devel] [PATCH 07/13] usb: Convert usb_packet_{map, unmap} to universal DMA helpers, David Gibson, 2012/06/19
- Re: [Qemu-devel] [PATCH 07/13] usb: Convert usb_packet_{map, unmap} to universal DMA helpers, Benjamin Herrenschmidt, 2012/06/19
- Re: [Qemu-devel] [PATCH 07/13] usb: Convert usb_packet_{map, unmap} to universal DMA helpers, David Gibson, 2012/06/20
- Re: [Qemu-devel] [PATCH 07/13] usb: Convert usb_packet_{map, unmap} to universal DMA helpers, Gerd Hoffmann, 2012/06/20