[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCHv3 11/14] unicore32-softmmu: Add puv3 pm support
From: |
Guan Xuetao |
Subject: |
Re: [Qemu-devel] [PATCHv3 11/14] unicore32-softmmu: Add puv3 pm support |
Date: |
Wed, 20 Jun 2012 10:00:22 +0800 |
On Mon, 2012-06-18 at 20:05 +0000, Blue Swirl wrote:
[snip]
> > +static void puv3_pm_write(void *opaque, target_phys_addr_t offset,
> > + uint64_t value, unsigned size)
> > +{
> > + PUV3PMState *s = (PUV3PMState *) opaque;
> > +
> > + switch (offset) {
> > + case 0x0:
> > + s->reg_PMCR = value;
>
> Missing 'break' or a comment about fall through.
Yes, 'break' is missed here.
Thanks ever so much.
Guan Xuetao
- Re: [Qemu-devel] [PATCHv3 07/14] unicore32-softmmu: Add puv3 soc/board support, (continued)
[Qemu-devel] [PATCHv3 10/14] unicore32-softmmu: Add puv3 gpio support, Guan Xuetao, 2012/06/18
[Qemu-devel] [PATCHv3 08/14] unicore32-softmmu: Add puv3 interrupt support, Guan Xuetao, 2012/06/18
[Qemu-devel] [PATCHv3 14/14] unicore32-softmmu: Add maintainer information for UniCore32 machine, Guan Xuetao, 2012/06/18
[Qemu-devel] [PATCHv3 09/14] unicore32-softmmu: Add puv3 ostimer support, Guan Xuetao, 2012/06/18
[Qemu-devel] [PATCHv3 05/14] unicore32-softmmu: Implement softmmu specific functions, Guan Xuetao, 2012/06/18
[Qemu-devel] [PATCHv3 13/14] unicore32-softmmu: Add ps2 support, Guan Xuetao, 2012/06/18
[Qemu-devel] [PATCHv3 11/14] unicore32-softmmu: Add puv3 pm support, Guan Xuetao, 2012/06/18