Re: [Qemu-devel] [PATCH v2] net: roll back qdev_prop_vlan

[Stefan Hajnoczi]

On Mon, Jun 18, 2012 at 1:57 PM,  <address@hidden> wrote:
> From: Zhi Yong Wu <address@hidden>
>
> We're trying to preserve backward compatibility.  This
> command-line break:
>
> x86_64-softmmu/qemu-system-x86_64 -net user,vlan=1 -device 
> virtio-net-pci,vlan=1
>
> Instead of dropping the qdev_prop_vlan completely the
> hw/qdev-properties.c code needs to call net/hub.h external functions
> to implement equivalent functionality.
>
> The change from v1:
>  1.) %d -> %u [stefanha]
>  2.) the error handling when net_hub_id_for_client fails [stefanha]
>
> Signed-off-by: Zhi Yong Wu <address@hidden>
> ---
>  hw/qdev-properties.c |   77 
> ++++++++++++++++++++++++++++++++++++++++++++++++++
>  hw/qdev.h            |    3 ++
>  net.h                |    1 +
>  net/hub.c            |   25 ++++++++++++++++
>  net/hub.h            |    1 +
>  5 files changed, 107 insertions(+), 0 deletions(-)

Reviewed-by: Stefan Hajnoczi <address@hidden>