[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 0/4] fdc: fix/rewrite seek, media_changed and
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PATCH v5 0/4] fdc: fix/rewrite seek, media_changed and interrupt handling |
Date: |
Thu, 14 Jun 2012 16:08:39 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:12.0) Gecko/20120430 Thunderbird/12.0.1 |
Am 13.06.2012 15:43, schrieb Pavel Hrdina:
> The fd_seek will return 'track is invalid' if there is no media in drive.
>
> Implied seek should have the same behavior as normal seek. We will use the
> fd_seek
> function instead of a direct modification of head, track and sector values.
> The result value is used only while read/write commands were issued.
>
> Fixed sense interrupt status command.
>
> v5:
> - correction of misspelled words
>
> v4:
> - fixed coding style
> - better bit clearing in 'fdctrl_handle_sense_interrupt_status'
>
> v3:
> - added fdc-test
> - rewrited seek and media_changed handling
> - fixed interrupt status handling
>
> v2:
> - better way to detect media missing
>
> Pavel Hrdina (4):
> fdc: fix implied seek while there is no media in drive
> fdc-test: introduced qtest read_without_media
> fdc: rewrite seek and DSKCHG bit handling
> fdc: fix interrupt handling
>
> hw/fdc.c | 106
> ++++++++++++++++++++++++++++++------------------------
> tests/fdc-test.c | 66 +++++++++++++++++++++++++++++++++
> 2 files changed, 125 insertions(+), 47 deletions(-)
>
Thanks, I applied patches 1 and 2. For the rest I'm waiting for a v6
that includes test cases.
Kevin
- [Qemu-devel] [PATCH v5 0/4] fdc: fix/rewrite seek, media_changed and interrupt handling, Pavel Hrdina, 2012/06/13
- [Qemu-devel] [PATCH v5 2/4] fdc-test: introduced qtest read_without_media, Pavel Hrdina, 2012/06/13
- [Qemu-devel] [PATCH v5 3/4] fdc: rewrite seek and DSKCHG bit handling, Pavel Hrdina, 2012/06/13
- [Qemu-devel] [PATCH v5 4/4] fdc: fix interrupt handling, Pavel Hrdina, 2012/06/13
- [Qemu-devel] [PATCH v5 1/4] fdc: fix implied seek while there is no media in drive, Pavel Hrdina, 2012/06/13
- Re: [Qemu-devel] [PATCH v5 0/4] fdc: fix/rewrite seek, media_changed and interrupt handling,
Kevin Wolf <=