Re: [Qemu-devel] [PATCH v2 1/6] qerror: add MAX_KEYCODES 16

[Amos Kong]

On 12/06/12 01:25, Luiz Capitulino wrote:
> >

Hi Luiz, Anthony

> >  BTW, why is there a 16 keycode limit?

'Sendkey' command was added by this commit 
a3a91a355bc6107b7d06d722fb97d2b80065ee0b
Limitation of keycodes number (16) was also introduced here,
and I didn't find the root reason.

> >
> That's a good point. This comes form the array used by the original
> implementation to store the keycodes.
>
> Amos, is it still needed now that we're using qapi lists?


I try to drop this limitation from monitor.c [1], then execute

(qemu) sendkey 1-2-3-4-5-6-7-8-9-0-1-2-3-4-5-6-7-8-9-0

kbd_put_keycode() are called for all (20) keycodes,
but only '123456789012345' can be sent to guest.


It seems we need to notice user when inputted keys are more than 16.


[1] 
https://github.com/kongove/QEMU/commit/a198cdcce3ce4c1632221ac7f1e7c4e8efcd9c82



--
                        Amos.