[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH V12 5/9] Revert "pci: don't export an internal f
From: |
Jan Kiszka |
Subject: |
Re: [Qemu-devel] [PATCH V12 5/9] Revert "pci: don't export an internal function" |
Date: |
Wed, 13 Jun 2012 14:48:13 +0200 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 |
On 2012-06-13 14:40, Anthony PERARD wrote:
> On 13/06/12 13:00, Jan Kiszka wrote:
>> On 2012-06-13 13:22, Stefano Stabellini wrote:
>>> On Wed, 13 Jun 2012, Jan Kiszka wrote:
>>>> On 2012-06-12 17:15, Michael S. Tsirkin wrote:
>>>>> On Tue, Jun 12, 2012 at 04:05:19PM +0100, Anthony PERARD wrote:
>>>>>> This reverts commit 94a09e2c846374a96719cda2b4e1312d8c4b08a7.
>>>>>>
>>>>>> This function is used by a later patch to parse the BDF of the device to
>>>>>> passthrough.
>>>>>>
>>>>>> Signed-off-by: Anthony PERARD<address@hidden>
>>>>>
>>>>> You probably want to parse the host address? You don't want to copy the
>>>>> bugs in pci_parse_devaddr - write your own that has sane semantics
>>>>> for host. E.g. you need to support ARI etc.
>>>>
>>>> We should really consolidate over one parser for Xen, KVM device
>>>> assignment and VFIO. It looks like they all have very similar requirements.
>>>>
>>>> For those how didn't follow the discussion, see patches 10-13 in
>>>> http://thread.gmane.org/gmane.comp.emulators.qemu/153728.
>>>
>>> I agree, actually it looks like patch 10 and 11 would be enough.
>>>
>>> Maybe you could extract them and send them out separately?
>>
>> They are still under discussion and waiting for some QOM refactorings to
>> be merged.
>>
>> Will you be able to use an address parser via some device property?
>
> Yes. Actually, the address is already a device property.
>
Great. Then we should try to come up with a common pci-host-devaddr
property everyone can use.
Jan
--
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux
- Re: [Qemu-devel] [PATCH V12 5/9] Revert "pci: don't export an internal function", (continued)
- Re: [Qemu-devel] [PATCH V12 5/9] Revert "pci: don't export an internal function", Michael S. Tsirkin, 2012/06/13
- Re: [Qemu-devel] [PATCH V12 5/9] Revert "pci: don't export an internal function", Jan Kiszka, 2012/06/13
- Re: [Qemu-devel] [PATCH V12 5/9] Revert "pci: don't export an internal function", Michael S. Tsirkin, 2012/06/13
- Re: [Qemu-devel] [PATCH V12 5/9] Revert "pci: don't export an internal function", Jan Kiszka, 2012/06/13
- Re: [Qemu-devel] [PATCH V12 5/9] Revert "pci: don't export an internal function", Michael S. Tsirkin, 2012/06/13
- Re: [Qemu-devel] [PATCH V12 5/9] Revert "pci: don't export an internal function", Stefano Stabellini, 2012/06/13
- Re: [Qemu-devel] [PATCH V12 5/9] Revert "pci: don't export an internal function", Jan Kiszka, 2012/06/13
- Re: [Qemu-devel] [PATCH V12 5/9] Revert "pci: don't export an internal function", Andreas Färber, 2012/06/13
- Re: [Qemu-devel] [PATCH V12 5/9] Revert "pci: don't export an internal function", Jan Kiszka, 2012/06/13
- Re: [Qemu-devel] [PATCH V12 5/9] Revert "pci: don't export an internal function", Anthony PERARD, 2012/06/13
- Re: [Qemu-devel] [PATCH V12 5/9] Revert "pci: don't export an internal function",
Jan Kiszka <=
- Re: [Qemu-devel] [PATCH V12 5/9] Revert "pci: don't export an internal function", Anthony PERARD, 2012/06/14
- Re: [Qemu-devel] [PATCH V12 5/9] Revert "pci: don't export an internal function", Jan Kiszka, 2012/06/14
- Re: [Qemu-devel] [PATCH V12 5/9] Revert "pci: don't export an internal function", Anthony PERARD, 2012/06/14
- Re: [Qemu-devel] [PATCH V12 5/9] Revert "pci: don't export an internal function", Michael S. Tsirkin, 2012/06/14
- Re: [Qemu-devel] [PATCH V12 5/9] Revert "pci: don't export an internal function", Anthony PERARD, 2012/06/14
[Qemu-devel] [PATCH V12 1/9] pci_ids: Add INTEL_82599_SFP_VF id., Anthony PERARD, 2012/06/12
[Qemu-devel] [PATCH V12 8/9] Introduce apic-msidef.h, Anthony PERARD, 2012/06/12
[Qemu-devel] [PATCH V12 7/9] Introduce Xen PCI Passthrough, PCI config space helpers (2/3), Anthony PERARD, 2012/06/12
[Qemu-devel] [PATCH V12 6/9] Introduce Xen PCI Passthrough, qdevice (1/3), Anthony PERARD, 2012/06/12
[Qemu-devel] [PATCH V12 9/9] Introduce Xen PCI Passthrough, MSI (3/3), Anthony PERARD, 2012/06/12