[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH V12 5/9] Revert "pci: don't export an internal f
From: |
Michael S. Tsirkin |
Subject: |
Re: [Qemu-devel] [PATCH V12 5/9] Revert "pci: don't export an internal function" |
Date: |
Tue, 12 Jun 2012 18:15:57 +0300 |
On Tue, Jun 12, 2012 at 04:05:19PM +0100, Anthony PERARD wrote:
> This reverts commit 94a09e2c846374a96719cda2b4e1312d8c4b08a7.
>
> This function is used by a later patch to parse the BDF of the device to
> passthrough.
>
> Signed-off-by: Anthony PERARD <address@hidden>
You probably want to parse the host address? You don't want to copy the
bugs in pci_parse_devaddr - write your own that has sane semantics
for host. E.g. you need to support ARI etc.
> ---
> hw/pci.c | 2 +-
> hw/pci.h | 2 ++
> 2 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/hw/pci.c b/hw/pci.c
> index eec106a..5bddf7a 100644
> --- a/hw/pci.c
> +++ b/hw/pci.c
> @@ -479,7 +479,7 @@ static void pci_set_default_subsystem_id(PCIDevice
> *pci_dev)
> * Parse [[<domain>:]<bus>:]<slot>, return -1 on error if funcp == NULL
> * [[<domain>:]<bus>:]<slot>.<func>, return -1 on error
> */
> -static int pci_parse_devaddr(const char *addr, int *domp, int *busp,
> +int pci_parse_devaddr(const char *addr, int *domp, int *busp,
> unsigned int *slotp, unsigned int *funcp)
> {
> const char *p;
> diff --git a/hw/pci.h b/hw/pci.h
> index ecf37fd..b169c0b 100644
> --- a/hw/pci.h
> +++ b/hw/pci.h
> @@ -321,6 +321,8 @@ PCIDevice *pci_find_device(PCIBus *bus, int bus_num,
> uint8_t devfn);
> int pci_qdev_find_device(const char *id, PCIDevice **pdev);
> PCIBus *pci_get_bus_devfn(int *devfnp, const char *devaddr);
>
> +int pci_parse_devaddr(const char *addr, int *domp, int *busp,
> + unsigned int *slotp, unsigned int *funcp);
> int pci_read_devaddr(Monitor *mon, const char *addr, int *domp, int *busp,
> unsigned *slotp);
>
> --
> Anthony PERARD
- [Qemu-devel] [PATCH V12 0/9] Xen PCI Passthrough, Anthony PERARD, 2012/06/12
- Re: [Qemu-devel] [PATCH V12 5/9] Revert "pci: don't export an internal function", Stefano Stabellini, 2012/06/13
- Re: [Qemu-devel] [PATCH V12 5/9] Revert "pci: don't export an internal function", Jan Kiszka, 2012/06/13
- Re: [Qemu-devel] [PATCH V12 5/9] Revert "pci: don't export an internal function", Andreas Färber, 2012/06/13
- Re: [Qemu-devel] [PATCH V12 5/9] Revert "pci: don't export an internal function", Jan Kiszka, 2012/06/13