Re: [Qemu-devel] [PATCH] w32: Fix broken build (missing include file)

[Wen Congyang]

At 06/07/2012 09:45 PM, Stefan Weil Wrote:
> dump.c was recently added to the code. It unconditionally
> includes sys/procfs which is not available with MinGW (w32, w64).
> 
> It looks like this file is not needed at all (tested on Linux),
> so I removed it completely.
> 
> Some other include statements are also redundant because they are
> already included in qemu-common, therefore they were removed, too.
> 
> Signed-off-by: Stefan Weil <address@hidden>

Thanks for your fix. It is OK to me.

Wen Congyang

> ---
> 
> dump.* use GPL2 instead of GPL2+. Please fix that!
> 
> Regards,
> Stefan Weil
> 
> 
>  dump.c |    4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/dump.c b/dump.c
> index 0ca14f8..f44ce47 100644
> --- a/dump.c
> +++ b/dump.c
> @@ -12,10 +12,7 @@
>   */
>  
>  #include "qemu-common.h"
> -#include <unistd.h>
>  #include "elf.h"
> -#include <sys/procfs.h>
> -#include <glib.h>
>  #include "cpu.h"
>  #include "cpu-all.h"
>  #include "targphys.h"
> @@ -23,7 +20,6 @@
>  #include "kvm.h"
>  #include "dump.h"
>  #include "sysemu.h"
> -#include "bswap.h"
>  #include "memory_mapping.h"
>  #include "error.h"
>  #include "qmp-commands.h"