Re: [Qemu-devel] [PATCH 1/3] hw/xilinx_*: Share Xilinx devices between ppc and microblaze

[Andreas Färber]

Hi,

Am 09.06.2012 04:15, schrieb Peter Crosthwaite:
> On Sat, Jun 9, 2012 at 11:54 AM, Andreas Färber <address@hidden> wrote:
>> Speeds up the build.
>>
>> xilinx_ethlite uses tswap32() and is thus target-dependent.
>>
>> Signed-off-by: Andreas Färber <address@hidden>
[...]
>> --- a/hw/Makefile.objs
>> +++ b/hw/Makefile.objs
>> @@ -59,6 +59,11 @@ hw-obj-$(CONFIG_PIIX4) += piix4.o
>>  hw-obj-$(CONFIG_G364FB) += g364fb.o
>>  hw-obj-$(CONFIG_JAZZ_LED) += jazz_led.o
>>
>> +# Xilinx devices
>> +hw-obj-$(CONFIG_XILINX) += xilinx_intc.o
>> +hw-obj-$(CONFIG_XILINX) += xilinx_timer.o
>> +hw-obj-$(CONFIG_XILINX) += xilinx_uartlite.o
>> +
> 
> whats the plan with xilinx_axidma xilinx_axienet and  xilinx_ethlite?
> Should be fold them into this CONFIG_  or are these the exceptions to
> the rule as they are the annoying endian dependent ones?

The axi ones are in patch 3/3 as they are only used for microblaze, not
ppc, and they use qemu-log.h. Designed for pick-from-the-front*. :)

The ethlite has the endianness issue described in the cover letter. Once
solved, I'd expect it to be folded into CONFIG_XILINX as well, yes.

Obviously if you have better variable naming, feel free to suggest or to
change before Edgar applies, my stake is only that the variable names
match in both places and that we achieve some deduplification.

Cheers,
Andreas

* Depending on whether this or Blue's series goes in first, in which
case 2/3 gets obsoleted.

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg