[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 06/10] qdev: generalize properties to Objects
From: |
Andreas Färber |
Subject: |
Re: [Qemu-devel] [PATCH 06/10] qdev: generalize properties to Objects |
Date: |
Wed, 30 May 2012 23:43:59 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:12.0) Gecko/20120421 Thunderbird/12.0 |
Am 23.05.2012 17:44, schrieb Paolo Bonzini:
> The property machinery uses DeviceState arguments in a few places.
> Replace this with Object so that we can push properties up.
>
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
> hw/qdev-addr.c | 19 +++---
> hw/qdev-properties.c | 180
> +++++++++++++++++++++-----------------------------
> hw/qdev.c | 8 +--
> hw/qdev.h | 10 +--
> 4 files changed, 93 insertions(+), 124 deletions(-)
>
> diff --git a/hw/qdev-addr.c b/hw/qdev-addr.c
> index a3796bd..99ca116 100644
> --- a/hw/qdev-addr.c
> +++ b/hw/qdev-addr.c
[...]
> @@ -53,9 +51,8 @@ static void set_taddr(Object *obj, Visitor *v, void *opaque,
> if ((uint64_t)value <= (uint64_t) ~(target_phys_addr_t)0) {
> *ptr = value;
> } else {
> - error_set(errp, QERR_PROPERTY_VALUE_OUT_OF_RANGE,
> - dev->id?:"", name, value, (uint64_t) 0,
> - (uint64_t) ~(target_phys_addr_t)0);
> + error_set(errp, QERR_INVALID_PARAMETER_VALUE,
> + name, "target_phys_addr_t");
Tab-indented here. Fixed for the upcoming version.
/-F
> }
> }
>
[snip]
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
- Re: [Qemu-devel] [PATCH 03/10] qom: push error reporting to object_property_find, (continued)
- [Qemu-devel] [PATCH 01/10] qdev: remove PropertyInfo range checking, Paolo Bonzini, 2012/05/23
- [Qemu-devel] [PATCH 02/10] qdev: remove qdev_prop_exists, Paolo Bonzini, 2012/05/23
- [Qemu-devel] [PATCH 05/10] qdev: push state up to Object, Paolo Bonzini, 2012/05/23
- [Qemu-devel] [PATCH 06/10] qdev: generalize properties to Objects, Paolo Bonzini, 2012/05/23
- Re: [Qemu-devel] [PATCH 06/10] qdev: generalize properties to Objects,
Andreas Färber <=
- [Qemu-devel] [PATCH 07/10] qdev: move bulk of qdev-properties.c to qom/object.c, Paolo Bonzini, 2012/05/23
- [Qemu-devel] [PATCH 09/10] qom: add realized property, Paolo Bonzini, 2012/05/23
- [Qemu-devel] [PATCH 10/10] qom: Add QERR_PROPERTY_SET_AFTER_REALIZE, Paolo Bonzini, 2012/05/23
- [Qemu-devel] [PATCH 04/10] qom: add get_id, Paolo Bonzini, 2012/05/23
- [Qemu-devel] [PATCH 08/10] qom: push static properties to Object, Paolo Bonzini, 2012/05/23