Re: [Qemu-devel] [PATCH for-1.1] Makefile: Fix QOM dependencies

[Andreas Färber]

Am 29.05.2012 11:50, schrieb Anthony Liguori:
> On 05/29/2012 04:47 AM, Andreas Färber wrote:
>> Am 29.05.2012 11:43, schrieb Paolo Bonzini:
>>> Il 29/05/2012 11:28, Andreas Färber ha scritto:
>>>> Am 29.05.2012 09:05, schrieb Gerd Hoffmann:
>>>>> -    rm -f slirp/*.o slirp/*.d audio/*.o audio/*.d block/*.o
>>>>> block/*.d net/*.o net/*.d fsdev/*.o fsdev/*.d ui/*.o ui/*.d
>>>>> qapi/*.o qapi/*.d qga/*.o qga/*.d
>>>>> -    rm -f qom/*.o qom/*.d
>>>>> +    rm -f slirp/*.o audio/*.o block/*.o net/*.o fsdev/*.o ui/*.o
>>>>> qapi/*.o qga/*.o
>>>>> +    rm -f qom/*.o
>>>>
>>>> I think this is calling for a centrally maintained (or automatically
>>>> derived) list of build directories.
>>>
>>> Quite difficult with the abuse of vpath that we currently have... but we
>>> can still proceed incrementally.
>>
>> For 1.1 I was thinking of something like
>>
>> BUILDSUBDIRS=slirp audio block net fsdev ui qapi qga qom
>>
>>     for dir in $(BUILDSUBDIRS); do \
>>         rm -rf $dir/*.o $dir/*.d; \
>>     done
>>
>> which possibly could also be reused for the list of *.d includes with
>> some clever macro usage.
> 
> I'd prefer not to make this change in 1.1.0 as this doesn't seem to be a
> release blocker to me.  I'd rather do something more significant in 1.2
> and backport to a 1.1.1 release.

Is "this change" referring to my patch, Gerd's attachment or my above
snippet?

I don't see it as a release blocker, but having proper dependencies in
the release would be good for people patching the tarball.

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg