[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-1.1 v2] slirp: Avoid redefining MAX_TCPOPTLE
From: |
Jan Kiszka |
Subject: |
Re: [Qemu-devel] [PATCH for-1.1 v2] slirp: Avoid redefining MAX_TCPOPTLEN |
Date: |
Mon, 28 May 2012 22:41:16 +0200 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 |
On 2012-05-28 19:52, Andreas Färber wrote:
> MAX_TCPOPTLEN is being defined as 32. Darwin already has it as 40,
> causing a warning. The value is only used to declare an array,
> into which currently 4 bytes are written at most.
>
> Therefore always override MAX_TCPOPTLEN for now.
>
> Suggested-by: Jan Kiszka <address@hidden>
> Signed-off-by: Andreas Färber <address@hidden>
> ---
> slirp/tcp_output.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/slirp/tcp_output.c b/slirp/tcp_output.c
> index 779314b..8aa3d90 100644
> --- a/slirp/tcp_output.c
> +++ b/slirp/tcp_output.c
> @@ -47,6 +47,7 @@ static const u_char tcp_outflags[TCP_NSTATES] = {
> };
>
>
> +#undef MAX_TCPOPTLEN
> #define MAX_TCPOPTLEN 32 /* max # bytes that go in options */
>
> /*
Thanks, queued for 1.1.
Jan
signature.asc
Description: OpenPGP digital signature