Re: [Qemu-devel] [PATCH 1.1] es1370: Fix debug code

[Andreas Färber]

Am 28.05.2012 17:18, schrieb malc:
> On Mon, 28 May 2012, Stefan Weil wrote:
> 
>> Am 28.05.2012 06:11, schrieb Peter Maydell:
>>> On 23 May 2012 22:26, Stefan Weil<address@hidden>  wrote:
>>>> When DEBUG_ES1370 is defined, the compiler shows these warnings:
>>>>
>>>> hw/es1370.c: In function ?es1370_update_voices?:
>>>> hw/es1370.c:414: warning: format ?%d? expects type ?int?, but argument 3
>>>> has type ?size_t?
>>> The unicode quotes in this commit message seem to have got smashed to
>>> question-mark characters at some point between this email and it hitting
>>> git master :-(
>>>
>>> -- PMM
>>
>> Malc, could you please check your git workflow?
> 
> Pine's '|' does that with my LC_CTYPE it seems, have to either ctrl-w 
> after '|' or export, either way - can do.

Recently I suspected your mailer and on one of the TCG threads suggested
to download from Patchwork instead.

But Patchwork also has its flaws: It tries to add *-bys from the
replies, in the order it receives them rather than where they were
placed and, like Anthony's mailbox script, it might pick up false
positives. And when there's line-wrapping in the original mail it might
silently drop part of the patch or in the combination of line-wrapping
and patch attachment drop and duplicate parts.

So if you can fix by some clever scripting that'll be safest. :)

Thanks,
Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg