Re: [Qemu-devel] [PATCH 3/4] hmp/qxl: info spice: add qxl info

[Alon Levy]

On Thu, May 24, 2012 at 02:58:40PM +0200, Gerd Hoffmann wrote:
> On 05/24/12 11:38, Alon Levy wrote:
> > For all devices print id, mode and guest_bug status.
> 
> Queued up 1+2+4

Please unqueue "qxl: stop dirty loging when not in vga mode" and I'll
send it again with the separate patch "hw/qxl: ignore guest from
guestbug until reset" that accidentally got squashed into it.

> 
> For this one I wanna have an additional ack from qmp camp.
> Also a nit:
> 
> >  # @SpiceInfo
> >  #
> >  # Information about the SPICE session.
> > @@ -683,12 +721,17 @@
> >  #
> >  # @channels: a list of @SpiceChannel for each active spice channel
> >  #
> > +# @qxl0_mode: Mode of the primary qxl device.
> > +#
> > +# @qxl0_guest_bug: Guest bug status of primary qxl device.
> > +#
> 
> Code changed, but docs didn't ...
> 
> Otherwise looks fine to me.
> 
> cheers,
>   Gerd
>