Re: [Qemu-devel] [PATCH 2/2] Add PIIX4 properties to control PM system states.

[Paolo Bonzini]

Il 23/05/2012 16:34, Andreas Färber ha scritto:
>> > 
>> > I see nothing wrong in principle here except that you should use a PTR
>> > property to pass the fw_cfg object to the ACPI PM device.
> Paolo was on a quest to eliminate the PTR properties so I don't think we
> should advocate adding any more. Without having reviewed the code, I
> would suggest to rather QOM'ify the fw_cfg object and to use a link<>
> property if needed.

Perhaps it should be the other way round.  fw_cfg gets links to all the
devices it has to expose information about.  In the future it could be
changed to an FWCfgProvider interface.

Paolo