[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [SeaBIOS] [PATCH 1/3] Fix aml_name_string() to recogniz
From: |
Gleb Natapov |
Subject: |
Re: [Qemu-devel] [SeaBIOS] [PATCH 1/3] Fix aml_name_string() to recognize block name modifiers. |
Date: |
Sun, 20 May 2012 14:13:20 +0300 |
On Sun, May 20, 2012 at 01:32:18PM +0300, Alon Levy wrote:
> On Sun, May 20, 2012 at 12:03:38PM +0300, Gleb Natapov wrote:
> >
> > Signed-off-by: Gleb Natapov <address@hidden>
> > ---
> > tools/acpi_extract.py | 6 +++++-
> > 1 files changed, 5 insertions(+), 1 deletions(-)
> >
> > diff --git a/tools/acpi_extract.py b/tools/acpi_extract.py
> > index 5f613e4..8038269 100755
> > --- a/tools/acpi_extract.py
> > +++ b/tools/acpi_extract.py
> > @@ -121,7 +121,11 @@ def aml_name_string(offset):
> > if (aml[offset] != 0x08):
> > die( "Name offset 0x%x: expected 0x08 actual 0x%x" %
> > (offset, aml[offset]));
> > - return offset + 1;
> > + offset += 1
> > + # Block Name Modifier. Skip it.
> > + if (aml[offset] == 0x5c or aml[offset] == 0x5e):
>
> You don't need parenthesis around the whole conditional.
Rest of the code has it. Better to keep same style :)
>
> > + offset += 1
> > + return offset;
> >
> > # Given data offset, find dword const offset
> > def aml_data_dword_const(offset):
> > --
> > 1.7.7.3
> >
> >
> > _______________________________________________
> > SeaBIOS mailing list
> > address@hidden
> > http://www.seabios.org/mailman/listinfo/seabios
--
Gleb.
- Re: [Qemu-devel] [PATCH 3/3] Get system state configuration from QEMU and patch DSDT with it., (continued)
- Re: [Qemu-devel] [PATCH 3/3] Get system state configuration from QEMU and patch DSDT with it., Avi Kivity, 2012/05/20
- Re: [Qemu-devel] [PATCH 3/3] Get system state configuration from QEMU and patch DSDT with it., Gleb Natapov, 2012/05/20
- Re: [Qemu-devel] [PATCH 3/3] Get system state configuration from QEMU and patch DSDT with it., Avi Kivity, 2012/05/20
- Re: [Qemu-devel] [PATCH 3/3] Get system state configuration from QEMU and patch DSDT with it., Gleb Natapov, 2012/05/20
- Re: [Qemu-devel] [PATCH 3/3] Get system state configuration from QEMU and patch DSDT with it., Kevin O'Connor, 2012/05/20
- Re: [Qemu-devel] [PATCH 3/3] Get system state configuration from QEMU and patch DSDT with it., Avi Kivity, 2012/05/20
- Re: [Qemu-devel] [PATCH 3/3] Get system state configuration from QEMU and patch DSDT with it., Kevin O'Connor, 2012/05/20
- Re: [Qemu-devel] [PATCH 3/3] Get system state configuration from QEMU and patch DSDT with it., Gleb Natapov, 2012/05/20
- Re: [Qemu-devel] [PATCH 3/3] Get system state configuration from QEMU and patch DSDT with it., Kevin O'Connor, 2012/05/20
Re: [Qemu-devel] [SeaBIOS] [PATCH 1/3] Fix aml_name_string() to recognize block name modifiers., Alon Levy, 2012/05/20
- Re: [Qemu-devel] [SeaBIOS] [PATCH 1/3] Fix aml_name_string() to recognize block name modifiers.,
Gleb Natapov <=
Re: [Qemu-devel] [PATCH 1/3] Fix aml_name_string() to recognize block name modifiers., Kevin O'Connor, 2012/05/22