Re: [Qemu-devel] [PATCH] Fix size checking in load_image_targphys to accept max_size > INT_MAX

[Alexander Graf]

On 16.05.2012, at 12:29, Christian Borntraeger wrote:

> On 03/05/12 16:33, Peter Maydell wrote:
>> On 3 May 2012 15:27, Christian Borntraeger <address@hidden> wrote:
>>> commit 17df768c1e4580f03301d18ea938d3557d441911
>>>  load_image_targphys() should enforce the max size
>>> 
>>> caused some problems with external kernel and specific ram sizes on s390:
>>> 
>>> We load the external kernel with
>>> 
>>> [...]
>>>          kernel_size = load_image_targphys(kernel_filename, 0, ram_size);
>>> [...]
>>> 
>>> Since load_image_targphys is declared as taking an int for max_sz, this will
>>> fail for ram sizes > INT_MAX.
>>> Lets change the max_sz parameter to a uint64_t.
>>> 
>>> Signed-off-by: Christian Borntraeger <address@hidden>
>> 
>> A patch equivalent to this has already been submitted:
>> http://patchwork.ozlabs.org/patch/146165/
>> We should be applying that one, it has already been reviewed.
>> 
>> Anthony?
> 
> Anthony,
> 
> can you apply the patchwork patch for 1.1?

Ping? Still missing in rc2.


Alex