[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 07/25] qdev: use object_property_print in info q
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH 07/25] qdev: use object_property_print in info qtree |
Date: |
Wed, 16 May 2012 03:40:12 -0400 (EDT) |
> Am 03.04.2012 15:05, schrieb Paolo Bonzini:
> > Il 03/04/2012 14:28, Jan Kiszka ha scritto:
> >>>> if (object_property_get_type(OBJECT(dev), legacy_name,
> >>>> NULL)) {
> >>>> value = object_property_get_str(OBJECT(dev),
> >>>> legacy_name, &err);
> >> [...] We should either
> >> assert(print && parse) or handle their non-existence properly.
> >
> > Yes, asserting that print/parse are always present in pairs (if at
> > all) would be good.
>
> Paolo, has this issue been addressed somewhere?
No, but it's a simple assertion. It doesn't look like 1.1 material.
I should send and rebase the bus series today, I'll include it.
Paolo