[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1.1 0/4] Xen: Fix PV-on-HVM
From: |
Stefano Stabellini |
Subject: |
Re: [Qemu-devel] [PATCH 1.1 0/4] Xen: Fix PV-on-HVM |
Date: |
Tue, 15 May 2012 19:20:23 +0100 |
User-agent: |
Alpine 2.00 (DEB 1167 2008-08-23) |
On Tue, 15 May 2012, Anthony PERARD wrote:
> In the context of PV-on-HVM under Xen, the emulated nics are supposed to be
> unplug before the guest drivers are initialized. This mean that there must be
> unplug without the consent of the guest.
>
> Without this patch series, the guest end up with two nics with the same MAC,
> the emulated nic and the PV nic.
>
> I tried few other path before to submite these patches:
> - delayed the hot unplug in QEMU until the guest initialize the hotplug.
> => the guest unplug the nic only after the driver initialized it. That's a
> bit late.
> - delayed the call to unplug the emulated device until pci_acpi_init is
> called
> => this is worse, the pv disc does not show up and the guest does not
> boot.
>
> In order to achive this fix, these patches introduce a new hotplug state only
> used in acpi_piix4, and a new qdev callback force_unplug.
>
> Would it be possible to have this fix in the next release?
I would be in favor for having this fix in 1.1.
Apart from the two comments I sent, I think that the patch series looks
reasonable.
- Re: [Qemu-devel] [PATCH 1/4] Introduce a new hotplug state: Force eject., (continued)
- Re: [Qemu-devel] [PATCH 1/4] Introduce a new hotplug state: Force eject., Paolo Bonzini, 2012/05/16
- Re: [Qemu-devel] [PATCH 1/4] Introduce a new hotplug state: Force eject., Anthony PERARD, 2012/05/16
- Re: [Qemu-devel] [PATCH 1/4] Introduce a new hotplug state: Force eject., Michael S. Tsirkin, 2012/05/16
- Re: [Qemu-devel] [PATCH 1/4] Introduce a new hotplug state: Force eject., Paolo Bonzini, 2012/05/16
- Re: [Qemu-devel] [PATCH 1/4] Introduce a new hotplug state: Force eject., Michael S. Tsirkin, 2012/05/16
- Re: [Qemu-devel] [PATCH 1/4] Introduce a new hotplug state: Force eject., Anthony Liguori, 2012/05/16
- Re: [Qemu-devel] [PATCH 1/4] Introduce a new hotplug state: Force eject., Michael S. Tsirkin, 2012/05/16
[Qemu-devel] [PATCH 3/4] pci: Add force_unplug callback., Anthony PERARD, 2012/05/15
Re: [Qemu-devel] [PATCH 1.1 0/4] Xen: Fix PV-on-HVM, Anthony Liguori, 2012/05/15
Re: [Qemu-devel] [PATCH 1.1 0/4] Xen: Fix PV-on-HVM,
Stefano Stabellini <=
Re: [Qemu-devel] [PATCH 1.1 0/4] Xen: Fix PV-on-HVM, Michael S. Tsirkin, 2012/05/15