[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 10/13] pci: export pci_user functions for use by
From: |
Bjorn Helgaas |
Subject: |
Re: [Qemu-devel] [PATCH 10/13] pci: export pci_user functions for use by other drivers |
Date: |
Mon, 14 May 2012 15:20:40 -0600 |
> diff --git a/include/linux/pci.h b/include/linux/pci.h
> index dc25da3..b437225 100644
> --- a/include/linux/pci.h
> +++ b/include/linux/pci.h
> @@ -770,6 +770,14 @@ static inline int pci_write_config_dword(const struct
> pci_dev *dev, int where,
> return pci_bus_write_config_dword(dev->bus, dev->devfn, where, val);
> }
>
> +/* user-space driven config access */
> +extern int pci_user_read_config_byte(struct pci_dev *dev, int where, u8
> *val);
> +extern int pci_user_read_config_word(struct pci_dev *dev, int where, u16
> *val);
> +extern int pci_user_read_config_dword(struct pci_dev *dev, int where, u32
> *val);
> +extern int pci_user_write_config_byte(struct pci_dev *dev, int where, u8
> val);
> +extern int pci_user_write_config_word(struct pci_dev *dev, int where, u16
> val);
> +extern int pci_user_write_config_dword(struct pci_dev *dev, int where, u32
> val);
If you repost this, can you remove the externs when you move these
declarations? I know the file's currently a random mix, but we might
as well make a tiny improvement.
Looks fine to me otherwise, and if you don't have any other reason to
update this series, don't worry about it.
Acked-by: Bjorn Helgaas <address@hidden>
> int __must_check pci_enable_device(struct pci_dev *dev);
> int __must_check pci_enable_device_io(struct pci_dev *dev);
> int __must_check pci_enable_device_mem(struct pci_dev *dev);
>
- Re: [Qemu-devel] [PATCH 05/13] pci: New pci_acs_enabled(), (continued)
- Re: [Qemu-devel] [PATCH 05/13] pci: New pci_acs_enabled(), Alex Williamson, 2012/05/16
- Re: [Qemu-devel] RESEND3: Re: [PATCH 05/13] pci: New pci_acs_enabled(), Don Dutile, 2012/05/18
- Re: [Qemu-devel] [PATCH 05/13] pci: New pci_acs_enabled(), Alex Williamson, 2012/05/18
- Re: [Qemu-devel] [PATCH 05/13] pci: New pci_acs_enabled(), Don Dutile, 2012/05/21
- Re: [Qemu-devel] [PATCH 05/13] pci: New pci_acs_enabled(), Alex Williamson, 2012/05/21
- Re: [Qemu-devel] [PATCH 05/13] pci: New pci_acs_enabled(), Don Dutile, 2012/05/21
[Qemu-devel] [PATCH 06/13] iommu: Make use of DMA quirking and ACS enabled check for groups, Alex Williamson, 2012/05/11
[Qemu-devel] [PATCH 08/13] vfio: Add documentation, Alex Williamson, 2012/05/11
[Qemu-devel] [PATCH 07/13] vfio: VFIO core, Alex Williamson, 2012/05/11
[Qemu-devel] [PATCH 10/13] pci: export pci_user functions for use by other drivers, Alex Williamson, 2012/05/11
- Re: [Qemu-devel] [PATCH 10/13] pci: export pci_user functions for use by other drivers,
Bjorn Helgaas <=
[Qemu-devel] [PATCH 09/13] vfio: x86 IOMMU implementation, Alex Williamson, 2012/05/11
[Qemu-devel] [PATCH 11/13] pci: Create common pcibios_err_to_errno, Alex Williamson, 2012/05/11
[Qemu-devel] [PATCH 12/13] pci: Misc pci_reg additions, Alex Williamson, 2012/05/11
[Qemu-devel] [PATCH 13/13] vfio: Add PCI device driver, Alex Williamson, 2012/05/11