qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] Posting a patch?


From: Stefan Weil
Subject: Re: [Qemu-devel] Posting a patch?
Date: Mon, 14 May 2012 23:08:01 +0200
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.16) Gecko/20120506 Iceowl/1.0b1 Icedove/3.0.11

Am 14.05.2012 22:58, schrieb Anthony Liguori:
On 05/14/2012 03:53 PM, Peter Maydell wrote:
On 14 May 2012 21:30, Stefan Weil<address@hidden>  wrote:
if you use git for sending, you don't risk that your mailer destroys the
format of your patch.
I usually use these commands to send a single patch from the QEMU source
directory:

# Create the patch file (name depends on the subject line of your patch).
    git format-patch HEAD^
    # Check the patch (fix any issues which were found).
    scripts/checkpatch.pl 0001-*
    # Get the maintainer who is responsible (there is not always one).
    scripts/get_maintainer.pl 0001-*
    # Send the patch.
git send-email --to address@hidden --to "n.n<address@hidden>"
0001-*

If you do this more than once in the same git tree you'll regret it :-)
("git send-email 0001-*" will happily retransmit all the old 0001-foo
patches along with the new one...) I use git-format-patch's -o option to
put my sent patches in a separate directory so they don't clutter up the
working tree.

You can also do:

git send-email address@hidden HEAD~1

Which avoids any clutter.

... and also avoids nasty messages from checkpatch.pl :-)

But as this method tends to add clutter to the qemu code
or to the mailing list, it should be avoided.


Regards,

Anthony Liguori

Cheers,

Stefan W.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]