|
From: | Kevin Wolf |
Subject: | Re: [Qemu-devel] [PATCH, v2] qemu/xendisk: properly update stats in ioreq_release() |
Date: | Mon, 14 May 2012 13:53:25 +0200 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20120329 Thunderbird/11.0.1 |
Am 14.05.2012 12:30, schrieb Jan Beulich: > While for the "normal" case (called from blk_send_response_all()) > decrementing requests_finished is correct, doing so in the parse error > case is wrong; requests_inflight needs to be decremented instead. > > Change in v2: Adjust coding style. > > Signed-off-by: Jan Beulich <address@hidden> I think it would be nicer if a struct ioreq had an explicit state so that you don't have to pass the right state when releasing it. But anyway, the patch looks correct to me: Reviewed-by: Kevin Wolf <address@hidden>
[Prev in Thread] | Current Thread | [Next in Thread] |