qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH next v2 34/74] omap: Use cpu_arm_init() to store


From: Andreas Färber
Subject: Re: [Qemu-devel] [PATCH next v2 34/74] omap: Use cpu_arm_init() to store ARMCPU in omap_mpu_state_s
Date: Sun, 13 May 2012 22:30:56 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:12.0) Gecko/20120421 Thunderbird/12.0

Am 11.05.2012 14:52, schrieb Andreas Färber:
> Am 10.05.2012 23:38, schrieb Peter Maydell:
>> On 10 May 2012 01:14, Andreas Färber <address@hidden> wrote:
>>> Fix tab indentations of comments, add braces, use cpu_reset().
>>>
>>> Signed-off-by: Andreas Färber <address@hidden>
>>> ---
>>>  hw/nseries.c  |    6 +++---
>>>  hw/omap.h     |    2 +-
>>>  hw/omap1.c    |   20 +++++++++++---------
>>>  hw/omap2.c    |    8 ++++----
>>>  hw/omap_sx1.c |    2 +-
>>>  hw/palm.c     |    2 +-
>>>  6 files changed, 21 insertions(+), 19 deletions(-)
>>
>> There are some structs here which use the name 'cpu' for
>> a 'struct omap_mpu_state_s *', which leads to ugliness
>> like s->cpu->cpu->env. (We shouldn't be trying to fix that
>> here, just a passing comment.)
> 
> Now that we have qom-next, we are no longer limited to the concept of
> self-contained series so I can try to turn that into s->mpu->cpu->env
> the weekend. Not perfect either, but better distinguishable.

Patch sent, please review.

/-F

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg



reply via email to

[Prev in Thread] Current Thread [Next in Thread]