Re: [Qemu-devel] [PATCH 0/5] msi: Refactorings and reset

[Michael S. Tsirkin]

On Thu, May 10, 2012 at 03:22:11PM -0300, Jan Kiszka wrote:
> These patches had been sent before. I now rebased them and reduced them
> to a set that has a value independent of the ongoing MSI rework for KVM
> integration.
> 
> I'm not yet sure if patch 1&2 should be considered for 1.1 as they
> implicitly fix the missing msi_reset for intel-hda and ahci. An
> alternative could be to add those reset calls the classic way and leave
> the refactoring for post-1.1. Maybe Gerd and Alex can comment on this.

I'd prefer that for 1.1, core changes are an unnecessary risk for 1.1.

> CC: Alexander Graf <address@hidden>
> CC: Gerd Hoffmann <address@hidden>
> CC: Isaku Yamahata <address@hidden>
> 
> Jan Kiszka (5):
>   msi: Guard msi_reset with msi_present
>   msi: Invoke msi/msix_reset from PCI core
>   msi: Guard msi/msix_write_config with msi_present
>   msi: Invoke msi/msix_write_config from PCI core
>   msi: Use msi/msix_present more consistently
> 
>  hw/ide/ich.c            |    8 --------
>  hw/intel-hda.c          |   12 ------------
>  hw/ioh3420.c            |    3 +--
>  hw/msi.c                |   11 ++++++++---
>  hw/msix.c               |   15 +++++++++------
>  hw/pci.c                |    8 ++++++++
>  hw/pci_bridge.c         |    4 ++++
>  hw/virtio-pci.c         |    3 ---
>  hw/xio3130_downstream.c |    3 +--
>  hw/xio3130_upstream.c   |    3 +--
>  10 files changed, 32 insertions(+), 38 deletions(-)
> 
> -- 
> 1.7.3.4